feat: Transfer frontend-template-application improvements by filippovskii09 · Pull Request #944 · openedx/frontend-template-application

filippovskii09 · 2025-10-16T10:02:03Z

Description

Transfer frontend-template-application improvements

Supporting information

As part of the work on creating a new MFE Catalog, frontend-template-application was taken as a template. Improvements and optimizations were made (in this PR) that would be useful to transfer to the upstream frontend-template-application (master branch) repository so that the development of further new MFEs would start with a template that is more prepared for this.

optimize and migrate changes from feat: Configure repository for new microfrontend PR to upstream frontend-template-application
ensure that the changes you open in the new PR for the upstream repository are universal and do not have any references to the Catalog MFE

Testing instructions

Please provide detailed step-by-step instructions for testing this change.

Deadline

"None" if there's no rush, or provide a specific date or event (and reason) if there is one.

Other information

Include anything else that will help reviewers and consumers understand the change.

Does this change depend on other changes elsewhere?
Any special concerns or limitations? For example: deprecations, migrations, security, or accessibility.
If your database migration can't be rolled back easily.

Note

The changes implemented in this PR were tested in the new MFE.

openedx-webhooks · 2025-10-16T10:02:09Z

Thanks for the pull request, @filippovskii09!

This repository is currently maintained by @openedx/committers-frontend.

Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review.

🔘 Get product approval

If you haven't already, check this list to see if your contribution needs to go through the product review process.

If it does, you'll need to submit a product proposal for your contribution, and have it reviewed by the Product Working Group.
- This process (including the steps you'll need to take) is documented here.
If it doesn't, simply proceed with the next step.

🔘 Provide context

To help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:

Dependencies

This PR must be merged before / after / at the same time as ...
Blockers

This PR is waiting for OEP-1234 to be accepted.
Timeline information

This PR must be merged by XX date because ...
Partner information

This is for a course on edx.org.
Supporting documentation
Relevant Open edX discussion forum threads

🔘 Get a green build

If one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green.

Details

Where can I find more information?

If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources:

When can I expect my changes to be merged?

Our goal is to get community contributions seen and reviewed as efficiently as possible.

However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:

The size and impact of the changes that it introduces
The need for product review
Maintenance status of the parent repository

💡 As a result it may take up to several weeks or months to complete a review and merge your PR.

PKulkoRaccoonGang · 2025-10-16T10:17:48Z

package.json

-    "lint": "fedx-scripts eslint --ext .js --ext .jsx .",
-    "lint:fix": "fedx-scripts eslint --fix --ext .js --ext .jsx .",
+    "stylelint": "stylelint \"plugins/**/*.scss\" \"src/**/*.scss\" \"scss/**/*.scss\" --config .stylelintrc.json",
+    "lint": "npm run stylelint && fedx-scripts eslint --ext .js --ext .jsx --ext .ts --ext .tsx .",


[nit]: Please add type checking to the linter

PKulkoRaccoonGang · 2025-10-16T10:20:43Z

package.json

+    "@edx/frontend-component-footer": "^14.9.2",
+    "@edx/frontend-component-header": "^8.0.0",


"@edx/frontend-component-header": "^8.0.0", "@edx/frontend-component-footer": "^14.9.2",

PKulkoRaccoonGang · 2025-10-16T10:21:47Z

package.json

+    "@edx/frontend-component-header": "^8.0.0",
    "@edx/frontend-platform": "^8.3.0",
    "@edx/openedx-atlas": "^0.7.0",
+    "@edx/paragon": "^21.5.6",


[important]: Please remove this old paragon package

PKulkoRaccoonGang · 2025-10-16T10:23:00Z

package.json

+    "@types/node": "^24.7.2",
+    "ajv": "^6.12.6",
+    "ajv-keywords": "^3.5.2",


[important]: Please check if we really need these packages.

i removed this packages and test local, they were unnecessary

Thanks! Resolved

PKulkoRaccoonGang · 2025-10-16T10:24:01Z

package.json

+    "jest": "30.2.0",
+    "stylelint": "^15.10.0",
+    "stylelint-config-standard": "^39.0.1",
+    "stylelint-scss": "^4.4.0"


[important]: Please check if we really need these packages.

i removed this packages and test local, they were unnecessary too

Nice! Resolved

codecov · 2025-10-17T12:59:46Z

Codecov Report

❌ Patch coverage is 0% with 8 lines in your changes missing coverage. Please review.
✅ Project coverage is 0.00%. Comparing base (2cadb33) to head (4a09d66).
⚠️ Report is 1 commits behind head on master.

Files with missing lines	Patch %	Lines
src/index.tsx	0.00%	8 Missing ⚠️

Additional details and impacted files

@@          Coverage Diff           @@
##           master    #944   +/-   ##
======================================
  Coverage    0.00%   0.00%           
======================================
  Files           2       3    +1     
  Lines           7      24   +17     
======================================
- Misses          7      24   +17

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

filippovskii09 · 2025-10-17T13:01:00Z

.stylelintrc.json

I took this configuration for .stylelintrc.json from this PR openedx/frontend-app-catalog#2

Is this the correct link openedx/openedx-platform#37480?

you're right, incorrect link, changed

[inform]: @bydawen is currently working on creating a separate issue to address the linter-related questions that came up during this discussion: openedx/frontend-app-catalog#2 (comment). So in the future, we might have fewer overrides and more unified configurations.

PKulkoRaccoonGang · 2025-10-17T16:37:14Z

package.json

+    "@openedx/paragon": "^23.14.8",
    "core-js": "3.46.0",
    "prop-types": "15.8.1",
    "react": "17.0.2",


I noticed that in the PR we’re transferring changes from, there was an upgrade of React and some other libraries.
Let’s bring those updates over as well and make sure everything works correctly.

https://github.com/openedx/frontend-app-catalog/pull/2/files#diff-7ae45ad102eab3b6d7e7896acd08c427a9b25b346470d7bc6507b6481575d519R49

The libraries that were removed or updated in that PR should also be removed or updated in this one.

Removed and update packages

PKulkoRaccoonGang · 2025-10-20T14:29:44Z

@filippovskii09 should the eslint configuration from the original PR we’re transferring changes from? You’ve transferred the stylelint config, but the eslint configuration hasn’t been brought over.

filippovskii09 · 2025-10-21T09:51:25Z

@filippovskii09 should the eslint configuration from the original PR we’re transferring changes from? You’ve transferred the stylelint config, but the eslint configuration hasn’t been brought over.

@PKulkoRaccoonGang you're right, added that

PKulkoRaccoonGang · 2025-10-22T07:37:11Z

@brian-smith-tcril we recently worked together on openedx/frontend-app-catalog#2, which set up frontend-template-application for the new Catalog MFE.

As part of that PR, we transferred all potentially necessary changes for the template repository - including linter configurations, React version upgrade, and TypeScript support.

Please take a look when you have a chance. Thank you!

arbrandes

Looks great! Thanks for this!

arbrandes · 2025-11-03T15:20:19Z

Do you mind resolving conflicts so we can merge it in?

filippovskii09 · 2025-11-03T17:47:41Z

@arbrandes conflicts were resolved

arbrandes · 2025-12-01T13:47:54Z

Apologies for the delay in merging!

feat: Transfer frontend-template-application improvements

e5e40d8

openedx-webhooks added the open-source-contribution PR author is not from Axim or 2U label Oct 16, 2025

openedx-webhooks added this to Contributions Oct 16, 2025

github-project-automation bot moved this to Needs Triage in Contributions Oct 16, 2025

PKulkoRaccoonGang reviewed Oct 16, 2025

View reviewed changes

mphilbrick211 moved this from Needs Triage to Waiting on Author in Contributions Oct 16, 2025

mphilbrick211 added the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 16, 2025

mphilbrick211 moved this from Waiting on Author to Needs Tests Run or CLA Signed in Contributions Oct 16, 2025

e0d removed the needs test run Author's first PR to this repository, awaiting test authorization from Axim label Oct 16, 2025

filippovskii09 requested a review from PKulkoRaccoonGang October 17, 2025 09:35

filippovskii09 marked this pull request as ready for review October 17, 2025 09:36

filippovskii09 added 3 commits October 17, 2025 12:50

fix: fix disscusions and some refactor

723138e

fix: correct header and footer packeges placement

bb232ae

fix: fix spacing

3a3d7e9

filippovskii09 force-pushed the filippovskii/feat/transfer-frontend-template-application-improvements branch from d635f85 to 3a3d7e9 Compare October 17, 2025 09:52

PKulkoRaccoonGang assigned filippovskii09 Oct 17, 2025

fix: ci fix for stylelint

b64bc28

filippovskii09 commented Oct 17, 2025

View reviewed changes

PKulkoRaccoonGang reviewed Oct 17, 2025

View reviewed changes

filippovskii09 added 2 commits October 20, 2025 14:48

fix: add correct changes for packages

8d6b34a

fix: fix lint errors

c269569

filippovskii09 added 2 commits October 21, 2025 10:25

fix: add correct eslint config

c4ab311

fix: remove extra package and fix jest config

dc71441

filippovskii09 requested a review from PKulkoRaccoonGang October 21, 2025 09:53

PKulkoRaccoonGang approved these changes Oct 21, 2025

View reviewed changes

PKulkoRaccoonGang requested a review from brian-smith-tcril October 22, 2025 07:38

mphilbrick211 moved this from Needs Tests Run or CLA Signed to In Eng Review in Contributions Oct 22, 2025

arbrandes approved these changes Nov 3, 2025

View reviewed changes

filippovskii09 added 2 commits November 3, 2025 18:42

fix: resolve conflict

a18b364

fix: update lock file

d7d221e

filippovskii09 requested a review from arbrandes November 4, 2025 16:48

filippovskii09 added the create-sandbox open-craft-grove should create a sandbox environment from this PR label Nov 6, 2025

fix: resolve conflicts

4a09d66

arbrandes merged commit 31b662c into openedx:master Dec 1, 2025
6 checks passed

github-project-automation bot moved this from In Eng Review to Done in Contributions Dec 1, 2025

		"@edx/frontend-component-footer": "^14.9.2",
		"@edx/frontend-component-header": "^8.0.0",

Conversation

filippovskii09 commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Supporting information

Testing instructions

Deadline

Other information

Uh oh!

openedx-webhooks commented Oct 16, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

codecov bot commented Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

filippovskii09 Oct 17, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

PKulkoRaccoonGang commented Oct 20, 2025

Uh oh!

filippovskii09 commented Oct 21, 2025

Uh oh!

PKulkoRaccoonGang commented Oct 22, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

arbrandes left a comment

Choose a reason for hiding this comment

Uh oh!

arbrandes commented Nov 3, 2025

Uh oh!

filippovskii09 commented Nov 3, 2025

Uh oh!

arbrandes commented Dec 1, 2025

Uh oh!

Uh oh!

Reviewers

filippovskii09 commented Oct 16, 2025 •

edited

Loading

openedx-webhooks commented Oct 16, 2025 •

edited

Loading

codecov bot commented Oct 17, 2025 •

edited

Loading

filippovskii09 Oct 17, 2025 •

edited

Loading

PKulkoRaccoonGang commented Oct 22, 2025 •

edited

Loading